fix: don't needlessly contrain join when the left side is allow to be null#60970
Open
icewind1991 wants to merge 1 commit into
Open
fix: don't needlessly contrain join when the left side is allow to be null#60970icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
icewind1991
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
icewind1991
force-pushed
the
partition-query-allow-null
branch
from
515952a to
b0a49e3
Compare
… null Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
partition-query-allow-null
branch
from
b0a49e3 to
0c3f48c
Compare
Member
Author
|
Integration tests fail due to #60953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the left side of a
LEFT JOINis constrained, we implicitly transform it into anINNER JOIN. With the reasoning being that a row needs to exist to satisfy the constraint.However, the constrain might still allow unset rows by allowing
nullvalues in the constraint. For example in: RuleManager::getRulesForFilesByParentThis changes it to only do the transform to
INNER JOINif the constraint doesn't allownullrows.Checklist
3. to review, feature component)stable32)AI (if applicable)